feat(design-requirements): default winding names to 'Winding N' and use them as row labels#23
Open
gpitel wants to merge 1 commit into
Open
Conversation
01a1acc to
5069f0e
Compare
…se them as row labels - Default new windings to 'Winding 1/2/3' (dynamic resize in DesignRequirements), instead of the isolation-side ordinals (Primary/Secondary/...). - Label the Isolation Sides rows with the (editable) winding name, consistent with the Turns Ratios rows, instead of the isolation-side ordinal. Pairs with a WebSharedComponents change defaulting the template winding names. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
5069f0e to
62f3fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Design Requirements editor, winding rows were labeled with the isolation-side ordinals (Primary, Secondary, …). In the Isolation Sides section the left column then repeated the dropdown's vocabulary, so a row read like a contradiction — e.g. "Secondary → Primary." The default winding name was itself "Primary/Secondary", which collides with the isolation-side tags.
Fix
Winding 1/2/3instead of the isolation-side ordinals. Windings added via the winding-count control are namedWinding N; the initial design templates are handled by the companion PR feat(defaults): default winding names to 'Winding N' WebSharedComponents#9.isolationSideOrdered.Net result: winding labels are consistent across Turns Ratios and Isolation Sides, they're editable, and a row reads unambiguously — "Winding 2 → Primary." The
isolationSideenum values are unchanged (still the dropdown options).Before / After
Before — left column repeats the isolation-group vocabulary:
After — left column identifies the winding (
Winding N):🤖 Generated with Claude Code