Skip to content

feat(design-requirements): default winding names to 'Winding N' and use them as row labels#23

Open
gpitel wants to merge 1 commit into
OpenMagnetics:mainfrom
gpitel:claude/isolation-winding-labels-upstream
Open

feat(design-requirements): default winding names to 'Winding N' and use them as row labels#23
gpitel wants to merge 1 commit into
OpenMagnetics:mainfrom
gpitel:claude/isolation-winding-labels-upstream

Conversation

@gpitel

@gpitel gpitel commented Jun 18, 2026

Copy link
Copy Markdown

Problem

In the Design Requirements editor, winding rows were labeled with the isolation-side ordinals (Primary, Secondary, …). In the Isolation Sides section the left column then repeated the dropdown's vocabulary, so a row read like a contradiction — e.g. "Secondary → Primary." The default winding name was itself "Primary/Secondary", which collides with the isolation-side tags.

Fix

  1. Default winding names to Winding 1/2/3 instead of the isolation-side ordinals. Windings added via the winding-count control are named Winding N; the initial design templates are handled by the companion PR feat(defaults): default winding names to 'Winding N' WebSharedComponents#9.
  2. Label the Isolation Sides rows with the winding name (editable — the same string the Turns Ratios rows already use) instead of isolationSideOrdered.

Net result: winding labels are consistent across Turns Ratios and Isolation Sides, they're editable, and a row reads unambiguously — "Winding 2 → Primary." The isolationSide enum values are unchanged (still the dropdown options).

Before / After

Before — left column repeats the isolation-group vocabulary:

before

After — left column identifies the winding (Winding N):

after

🤖 Generated with Claude Code

@gpitel gpitel marked this pull request as ready for review June 26, 2026 23:24
@gpitel gpitel force-pushed the claude/isolation-winding-labels-upstream branch from 01a1acc to 5069f0e Compare June 27, 2026 10:42
@gpitel gpitel changed the title fix(design-requirements): label isolation rows "Winding N", not "Primary/Secondary" fix(design-requirements): label per-winding rows 'WND<n>' Jun 27, 2026
…se them as row labels

- Default new windings to 'Winding 1/2/3' (dynamic resize in DesignRequirements),
  instead of the isolation-side ordinals (Primary/Secondary/...).
- Label the Isolation Sides rows with the (editable) winding name, consistent with
  the Turns Ratios rows, instead of the isolation-side ordinal.

Pairs with a WebSharedComponents change defaulting the template winding names.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@gpitel gpitel force-pushed the claude/isolation-winding-labels-upstream branch from 5069f0e to 62f3fe4 Compare June 27, 2026 13:48
@gpitel gpitel changed the title fix(design-requirements): label per-winding rows 'WND<n>' feat(design-requirements): default winding names to 'Winding N' and use them as row labels Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant